Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New platform for Microsoft Teams #27981

Merged
merged 5 commits into from Oct 23, 2019
Merged

New platform for Microsoft Teams #27981

merged 5 commits into from Oct 23, 2019

Conversation

peroyvind
Copy link
Contributor

@peroyvind peroyvind commented Oct 20, 2019

Description:

New notification platform for Microsoft Teams.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10911

Example entry for configuration.yaml (if applicable):

notify:
  - platform: msteams
    name: myteam
    webhook_id: https://outlook.office.com/webhook/<ID>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Copy link
Member

@pvizeli pvizeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only a last small comment and after that we can merge it

homeassistant/components/msteams/notify.py Show resolved Hide resolved
Dev automation moved this from Needs review to Reviewer approved Oct 22, 2019
@pvizeli pvizeli merged commit 852cbad into home-assistant:dev Oct 23, 2019
Dev automation moved this from Reviewer approved to Done Oct 23, 2019
@pvizeli
Copy link
Member

pvizeli commented Oct 23, 2019

Thanks

@lock lock bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants