Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New platform for Microsoft Teams #27981

Merged
merged 5 commits into from Oct 23, 2019

Conversation

@peroyvind
Copy link
Contributor

peroyvind commented Oct 20, 2019

Description:

New notification platform for Microsoft Teams.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10911

Example entry for configuration.yaml (if applicable):

notify:
  - platform: msteams
    name: myteam
    webhook_id: https://outlook.office.com/webhook/<ID>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Oct 20, 2019
@peroyvind peroyvind changed the title Msteams New platform for Microsoft Teams Oct 20, 2019
@peroyvind peroyvind referenced this pull request Oct 20, 2019
2 of 2 tasks complete
Copy link
Member

pvizeli left a comment

Looks good. Only a last small comment and after that we can merge it

Dev automation moved this from Needs review to Reviewer approved Oct 22, 2019
peroyvind added 5 commits Oct 20, 2019
@peroyvind peroyvind force-pushed the peroyvind:msteams branch from fc7b21a to bdcb008 Oct 22, 2019
@pvizeli pvizeli merged commit 852cbad into home-assistant:dev Oct 23, 2019
10 of 11 checks passed
10 of 11 checks passed
codecov/project 38.9% (target 90%)
Details
CI Build #20191022.34 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing acee87b...bdcb008
Details
Dev automation moved this from Reviewer approved to Done Oct 23, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Oct 23, 2019

Thanks

@lock lock bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.