Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports in everlights component #27983

Merged
merged 1 commit into from Oct 20, 2019
Merged

Move imports in everlights component #27983

merged 1 commit into from Oct 20, 2019

Conversation

djpremier
Copy link
Contributor

Description:

Moved imports from functions to top-level as requested in #27284

Related issue (if applicable): fixes #27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@project-bot project-bot bot added this to Needs review in Dev Oct 20, 2019
cgtobi
cgtobi approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from Needs review to Reviewer approved Oct 20, 2019
@cgtobi cgtobi merged commit ef8f88e into home-assistant:dev Oct 20, 2019
Dev automation moved this from Reviewer approved to Done Oct 20, 2019
@djpremier djpremier deleted the everlights_fix_imports branch October 20, 2019 22:01
@lock lock bot locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgtobi cgtobi cgtobi approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: everlights small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate integrations to use top-level imports
3 participants
@djpremier @cgtobi @homeassistant