Add bluesound speaker group attribute #28142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
changed the title
|
I'm a bit puzzeled. With the last commit the checks no longer pass. Says "Black failed", even though locally black is all fine... Can anybody help me how to handle this? |
|
Please rebase this PR onto the latest dev, that will fix your build issue. https://developers.home-assistant.io/docs/en/development_catching_up.html |
bluestripe
force-pushed
the
bluesound-group-attribute
branch
from
0e6ed15
to
e152b98
Compare
Thanks for the reply; I was a bit stuck. Done the rebase now, fingers crossed. |
MartinHjelmare
requested changes
Nov 3, 2019
bluestripe
force-pushed
the
bluesound-group-attribute
branch
from
e152b98
to
5985d95
Compare
|
Can be merged when build passes. |
|
Nice... Thanks for your review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
Added device attribute
bluesound_groupwith a list of entities that are in a speaker group (analogous to the sonos component) andmasterto indicate whether the device is the master. The master is the first item in the list, followed by one or more slaves.This change makes it possible for i.e. mini-media-player to properly display speaker groups of bluesound devices in much the same way as is done for Sonos devices already.
Checklist:
tox. Your PR cannot be merged unless tests pass