Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presentation URL to SSDP discovery info #28196

Merged
merged 1 commit into from Oct 25, 2019
Merged

Add presentation URL to SSDP discovery info #28196

merged 1 commit into from Oct 25, 2019

Conversation

scop
Copy link
Member

@scop scop commented Oct 25, 2019

Description:

Will be using the presentation URL for Huawei LTE; can get the API endpoint directly from there.

On the other hand, any particular reason why all of the SSDP device info wouldn't be made available in discovery_info, say for example under a ssdp_data key, e.g. like info[ATTR_SSDP_DATA] = device_info? Edit: filed that alternative as #28197

Related issue (if applicable): #28197

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Oct 25, 2019
@probot-home-assistant probot-home-assistant bot added integration: ssdp small-pr PRs with less than 30 lines. labels Oct 25, 2019
@scop scop changed the title Add friendly name and presentation URL to SSDP discovery info Add presentation URL to SSDP discovery info Oct 25, 2019
@scop
Copy link
Member Author

scop commented Oct 25, 2019

Oops, friendly name was already there, adjusted.

Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from Needs review to Reviewer approved Oct 25, 2019
@scop
Copy link
Member Author

scop commented Oct 25, 2019

@cgtobi do you have an opinion whether this or #28197 would be a better implementation?

@scop scop merged commit 3c4caaa into home-assistant:dev Oct 25, 2019
Dev automation moved this from Reviewer approved to Done Oct 25, 2019
@scop scop deleted the ssdp-attrs branch October 25, 2019 17:09
@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants