Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Xiaomi Air Quality Monitor support (cgllc.airmonitor.b1) #28301

Conversation

syssi
Copy link
Member

@syssi syssi commented Oct 28, 2019

Description:

Fixes #27735

@fwestenberg Could you provide some testing? Especially is the unique_id properly generated?

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11027

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (xiaomi_miio) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 28, 2019
@codecov

This comment has been minimized.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from By Code Owner to Reviewer approved Oct 29, 2019
@syssi
Copy link
Member Author

syssi commented Oct 29, 2019

Thanks for your patience! :-)

@MartinHjelmare MartinHjelmare merged commit 6d734a7 into home-assistant:dev Oct 29, 2019
Dev automation moved this from Reviewer approved to Done Oct 29, 2019
@fwestenberg
Copy link
Contributor

IMG_20191028_220339

Here's the unique_id of my device. Seems right!

@lock lock bot locked and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants