New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Xiaomi Air Quality Monitor support (cgllc.airmonitor.b1) #28301
Merged
MartinHjelmare
merged 6 commits into
home-assistant:dev
from
syssi:feature/xiaomi-miio-air-quality-cleanup
Oct 29, 2019
Merged
Clean up Xiaomi Air Quality Monitor support (cgllc.airmonitor.b1) #28301
MartinHjelmare
merged 6 commits into
home-assistant:dev
from
syssi:feature/xiaomi-miio-air-quality-cleanup
Oct 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
integration: xiaomi_miio
small-pr
PRs with less than 30 lines.
labels
Oct 28, 2019
Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration ( |
2 tasks
This comment has been minimized.
This comment has been minimized.
MartinHjelmare
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for your patience! :-) |
MartinHjelmare
approved these changes
Oct 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
by-code-owner
cla-signed
Hacktoberfest
integration: xiaomi_miio
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #27735
@fwestenberg Could you provide some testing? Especially is the
unique_id
properly generated?Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11027
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: