Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Abode cache file path, add cache path to config flow #28389

Merged
merged 7 commits into from Nov 2, 2019
Merged

Change Abode cache file path, add cache path to config flow #28389

merged 7 commits into from Nov 2, 2019

Conversation

MisterWil
Copy link
Contributor

@MisterWil MisterWil commented Oct 31, 2019 •
edited

Description:

Fixes a permission denied issue by passing in a cache path in the config flow. This commit also removes the CWD path ./ in the defined cache/pickle file location to match how several other components define their pickle file locations: feedreader logi_circle ring mopar

Related issue (if applicable): fixes #28242

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@project-bot project-bot bot added this to Needs review in Dev Oct 31, 2019
@probot-home-assistant
Copy link

Hey there @shred86, mind taking a look at this pull request as its been labeled with a integration (abode) you are listed as a codeowner for? Thanks!

@MisterWil MisterWil changed the title Changed Abode component cache file path Changed Abode cache file path Oct 31, 2019
@MisterWil MisterWil mentioned this pull request Oct 31, 2019
Closed
@MisterWil MisterWil changed the title Changed Abode cache file path Changed Abode cache file path, add cache path to config flow Oct 31, 2019
@arsaboo
Copy link
Contributor

arsaboo commented Oct 31, 2019

This fixes the issue...thanks @MisterWil

@MartinHjelmare MartinHjelmare changed the title Changed Abode cache file path, add cache path to config flow Change Abode cache file path, add cache path to config flow Nov 1, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 2, 2019
@balloob balloob added this to the 0.101.2 milestone Nov 2, 2019
@balloob balloob merged commit ad4a960 into home-assistant:dev Nov 2, 2019
Dev automation moved this from Reviewer approved to Done Nov 2, 2019
balloob pushed a commit that referenced this pull request Nov 2, 2019
@MisterWil @balloob
Change Abode cache file path, add cache path to config flow (#28389)
9e9537a 
* Changed cache file path

* Cache file naming scheme matches original

* Restart tests

* Adding cache path to config_flow.py

* Moved DEFAULT_CACHEDB to consts file

* Use correct cache path

* Linting issues
@balloob balloob mentioned this pull request Nov 2, 2019
Merged
@lock lock bot locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed Hacktoberfest integration: abode small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
0.101.2
Development

Successfully merging this pull request may close these issues.

Abode not working in 0.101
4 participants
@MisterWil @arsaboo @balloob @homeassistant