Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hdate spamming homeassistant log #28392

Merged
merged 2 commits into from Oct 31, 2019

Conversation

tsvi
Copy link
Contributor

@tsvi tsvi commented Oct 31, 2019

Breaking Change:

Description:

Fixes accidental spammy logger that got into v0.9.1 release.

Related issue (if applicable): fixes #28374

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Oct 31, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 31, 2019
@tsvi
Copy link
Contributor Author

tsvi commented Oct 31, 2019

@balloob Can we push this 0.101.1? The message is really very spammy.
Thanks,

@fabaff fabaff added this to the 0.101.1 milestone Oct 31, 2019
@balloob balloob merged commit 674860e into home-assistant:dev Oct 31, 2019
Dev automation moved this from By Code Owner to Done Oct 31, 2019
@tsvi tsvi deleted the jcal_bugfix_logger branch October 31, 2019 18:43
@tsvi tsvi restored the jcal_bugfix_logger branch October 31, 2019 18:47
balloob pushed a commit that referenced this pull request Oct 31, 2019
* Fix hdate spamming homeassistant log

* Lower verbosity of another spammy message
@balloob balloob mentioned this pull request Oct 31, 2019
@lock lock bot locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

hdate spamming logs [jewish_calendar integration]
4 participants