Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Airly if more than one config entry #28498

Merged
merged 1 commit into from Nov 3, 2019
Merged

Fix Airly if more than one config entry #28498

merged 1 commit into from Nov 3, 2019

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Nov 3, 2019

Breaking Change:

None

Description:

My stupid mistake cause issue with few instances of the integration. This PR fix that.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Nov 3, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 3, 2019
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Nov 3, 2019

Is there a github issue connected? Please describe what problem we're addressing and why this fixes it.

@MartinHjelmare MartinHjelmare changed the title Airly fix for few instances Fix Airly for few instances Nov 3, 2019
@bieniu
Copy link
Member Author

bieniu commented Nov 3, 2019

@MartinHjelmare If two instances of Airly integration are added, only the second one will be properly initialized at HA startup. First AirlyData object of config_entry will be removed from hass.data[DOMAIN][DATA_CLIENT] due this. This PR moves

hass.data[DOMAIN] = {}
hass.data[DOMAIN][DATA_CLIENT] = {}

to the right place: async_setup function.

This issue hasn't reported via GitHub. Someone from polish Home Assistant group on Facebook told me about that.

Dev automation moved this from By Code Owner to Reviewer approved Nov 3, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks!

@MartinHjelmare
Copy link
Member

Failed tests are unrelated and have already been fixed on dev branch.

@MartinHjelmare MartinHjelmare changed the title Fix Airly for few instances Fix Airly if more than one config entry Nov 3, 2019
@MartinHjelmare MartinHjelmare merged commit 4e40394 into home-assistant:dev Nov 3, 2019
Dev automation moved this from Reviewer approved to Done Nov 3, 2019
@MartinHjelmare MartinHjelmare added this to the 0.101.3 milestone Nov 4, 2019
@lock lock bot locked and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants