Add device triggers to vacuum #28548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
has-tests
integration: automation
integration: vacuum
labels
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
balloob
commented
Nov 5, 2019
| from homeassistant.components.device_automation import TRIGGER_BASE_SCHEMA | ||
| from . import DOMAIN, STATE_CLEANING, STATE_DOCKED, STATES | ||
|
|
||
| TRIGGER_TYPES = {"cleaning", "docked"} |
There was a problem hiding this comment.
This is only for the new vacuum devices, the old one should be removed (and should have been removed when we introduced the new one)
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add device triggers to vacuum devices.
Related issue (if applicable): fixes #27022
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: