Dsmr reader #28701
Merged
Dsmr reader #28701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
added 10 commits
November 12, 2019 03:41
- Added DSMR Reader platform - Updated codeowners for other components I added earlier
fabaff
requested changes
Nov 12, 2019
fabaff
approved these changes
Nov 28, 2019
| { | ||
| "domain": "dsmr_reader", | ||
| "name": "DSMR Reader", | ||
| "documentation": "https://www.home-assistant.io/components/dsmr_reader", |
There was a problem hiding this comment.
Please replace components with integrations in the url.
|
|
||
| from .definitions import DEFINITIONS | ||
|
|
||
| _LOGGER = logging.getLogger(__name__) |
|
|
||
| self._name = self._definition["name"] | ||
| self._unit_of_measurement = ( | ||
| self._definition["unit"] if "unit" in self._definition else "" |
There was a problem hiding this comment.
We can replace the ternary operator with dict.get. It's built for this case.
self._unit_of_measurement = self._definition.get("unit")There was a problem hiding this comment.
We shouldn't use empty string for unit of measurement. If there's no unit, return None as unit of measurement.
|
|
||
| self.async_schedule_update_ha_state() | ||
|
|
||
| return await mqtt.async_subscribe(self.hass, self._topic, message_received, 1) |
There was a problem hiding this comment.
async_added_to_hass shouldn't return anything. Please remove the return and just await here.
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for DSMR Reader to Home Assistant.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11156
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: