Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentherm_gw device support #28722

Merged
merged 4 commits into from Nov 27, 2019
Merged

Conversation

mvn23
Copy link
Contributor

@mvn23 mvn23 commented Nov 12, 2019

Breaking Change:

Breaks enabled sensor and binary_sensor entities, these are now disabled by default and can be re-enabled through the Devices panel.
Breaks entity_id of the climate entity in some configurations. The entity_id is now based on the gateway_id rather than the configured name to guarantee uniqueness.

Description:

Add device support to the opentherm_gw integration.

Related issue (if applicable): fixes #28378

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11163

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:
N/A

Dev automation moved this from Needs review to Review in progress Nov 13, 2019
Dev automation moved this from Review in progress to Reviewer approved Nov 14, 2019
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Nov 14, 2019

Regarding the breaking change, as long as the unique_id remains the same, changing the default entity_id will not be a breaking change for existing users.

@cgarwood cgarwood merged commit fdf0793 into home-assistant:dev Nov 27, 2019
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
@mvn23 mvn23 deleted the otgw-device-support branch November 17, 2020 17:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

OpenTherm device_info property missing
4 participants