Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing venstar operation_mode #28754

Merged
merged 1 commit into from Nov 15, 2019
Merged

Fix changing venstar operation_mode #28754

merged 1 commit into from Nov 15, 2019

Conversation

flamechair
Copy link
Contributor

@flamechair flamechair commented Nov 13, 2019

Description:

In the other PR for venstar, I accidentally did a conditional check against a value from self._mode_map when we should be checking the key

Example entry for configuration.yaml (if applicable):

climate:
  - platform: venstar
    host: !secret venstar_host
    humidifier: true
    timeout: 300

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Nov 13, 2019
@probot-home-assistant probot-home-assistant bot added integration: venstar small-pr PRs with less than 30 lines. labels Nov 13, 2019
@MartinHjelmare MartinHjelmare changed the title Small fix for changing operation_mode in venstar Fix changing venstar operation_mode Nov 15, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Nov 15, 2019
@MartinHjelmare MartinHjelmare added this to the 0.102.0 milestone Nov 15, 2019
@MartinHjelmare MartinHjelmare merged commit 3500084 into home-assistant:dev Nov 15, 2019
Dev automation moved this from Reviewer approved to Done Nov 15, 2019
@flamechair flamechair deleted the patch-1 branch November 16, 2019 03:38
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants