Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump herepy to 0.6.3.3 #28907

Merged
merged 2 commits into from Nov 20, 2019

Conversation

eifinger
Copy link
Contributor

Description:

Bump herepy to 0.6.3.3 and update tests to meet new structures.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Nov 20, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 20, 2019
Dev automation moved this from By Code Owner to Reviewer approved Nov 20, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @eifinger! 👍

@frenck frenck merged commit 9f181ac into home-assistant:dev Nov 20, 2019
Dev automation moved this from Reviewer approved to Done Nov 20, 2019
@eifinger eifinger deleted the here_travel_time_version_bump branch November 20, 2019 22:09
@lock lock bot locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants