New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update heatmiserv3 integration #29006
Merged
fabaff
merged 18 commits into
home-assistant:dev
from
andylockran:integrations/heatmiserv3
Dec 3, 2019
Merged
Update heatmiserv3 integration #29006
fabaff
merged 18 commits into
home-assistant:dev
from
andylockran:integrations/heatmiserv3
Dec 3, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: heatmiser
small-pr
PRs with less than 30 lines.
labels
Nov 24, 2019
Hi @andylockran, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
fabaff
requested changes
Nov 24, 2019
This was referenced Nov 25, 2019
MartinHjelmare
requested changes
Nov 26, 2019
Removed .get from config Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Removed .get from config Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Removed .get from config Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
…me-assistant into integrations/heatmiserv3
MartinHjelmare
approved these changes
Nov 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Can be merged when build passes. |
fabaff
approved these changes
Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
The current version of the heatmiser integration went out of date with the introduction of voluptuous. This has now been fixed, but it breaks the old config syntax slightly. See the updated docs for the new config format.
Description:
Update heatmiser component to latest version of the heatmiserV3 library, meaning less code inside HA, and more leverage on library.
Current version of the heatmiser integration went out of date with the introduction of voloptuous and it's taken me a long time to get the time to fix it. This fixes it, but breaks the old config syntax slightly. Submission to docs site has also been made, and references this PR.
Docs PR:
home-assistant/home-assistant.io#11290
Example entry for
configuration.yaml
(if applicable):*done on homeassistant.io PR.
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: