Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heatmiserv3 integration #29006

Merged
merged 18 commits into from Dec 3, 2019

Conversation

@andylockran
Copy link
Contributor

andylockran commented Nov 24, 2019

Breaking Change:

The current version of the heatmiser integration went out of date with the introduction of voluptuous. This has now been fixed, but it breaks the old config syntax slightly. See the updated docs for the new config format.

Description:

Update heatmiser component to latest version of the heatmiserV3 library, meaning less code inside HA, and more leverage on library.

Current version of the heatmiser integration went out of date with the introduction of voloptuous and it's taken me a long time to get the time to fix it. This fixes it, but breaks the old config syntax slightly. Submission to docs site has also been made, and references this PR.

Docs PR:

home-assistant/home-assistant.io#11290

Example entry for configuration.yaml (if applicable):

*done on homeassistant.io PR.



Checklist:

  • The code change is tested and works locally.
  • [] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • [] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 24, 2019

Hi @andylockran,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/manifest.json Outdated Show resolved Hide resolved
@fabaff fabaff changed the title Integrations/heatmiserv3 Update heatmiserv3 integration Nov 24, 2019
andylockran added 2 commits Nov 24, 2019
@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Nov 26, 2019
@home-assistant home-assistant deleted a comment from andylockran Nov 26, 2019
@home-assistant home-assistant deleted a comment from homeassistant Nov 26, 2019
@project-bot project-bot bot moved this from Review in progress to Needs review in Dev Nov 26, 2019
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
homeassistant/components/heatmiser/climate.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 26, 2019
andylockran and others added 5 commits Nov 30, 2019
Removed .get from config

Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Removed .get from config

Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Removed .get from config

Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
…me-assistant into integrations/heatmiserv3
requirements_all.txt Outdated Show resolved Hide resolved
andylockran added 3 commits Nov 30, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 30, 2019

Can be merged when build passes.

@andylockran andylockran requested a review from fabaff Nov 30, 2019
Dev automation moved this from Review in progress to Reviewer approved Dec 3, 2019
@fabaff
fabaff approved these changes Dec 3, 2019
@fabaff fabaff merged commit 434b783 into home-assistant:dev Dec 3, 2019
11 checks passed
11 checks passed
CI #20191130.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 5ef2357...a932768
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.