New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fan support to lutron_caseta #29033
Add fan support to lutron_caseta #29033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MartinHjelmare Modifications completed. Note I added an additional mapping for FAN_MEDIUM_HIGH: SPEED_MEDIUM. Found a bug when testing out the changes in this PR. When setting the fan speed the mediumhigh directly on the switch, it would cause an error because I did not map the additional lutron speed. It will seem that we need to revisit the concepts outlined in this architectural issue here as this seems to be a common occurrence for fan components: home-assistant/architecture#127 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@mdonoughe Ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Breaking Change:
Description:
Adding lutron caseta fan component using pylutron_caseta 0.5.1
Changes. Handle None returned from pylutron_caseta. Updates to use built in fan constants from pylutron_caseta.
Note: This is a re-pull of #24770 which could not be merged due to pylutron_caseta being abandoned. The project is up and running and ready to go.
Note: The PR for updating pylutron_caseta is here #28886 and must go hand and hand with this one.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9780
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: