Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fan support to lutron_caseta #29033

Merged
merged 10 commits into from Nov 28, 2019

Conversation

@djj211
Copy link
Contributor

djj211 commented Nov 24, 2019

Breaking Change:

Description:

Adding lutron caseta fan component using pylutron_caseta 0.5.1
Changes. Handle None returned from pylutron_caseta. Updates to use built in fan constants from pylutron_caseta.
Note: This is a re-pull of #24770 which could not be merged due to pylutron_caseta being abandoned. The project is up and running and ready to go.
Note: The PR for updating pylutron_caseta is here #28886 and must go hand and hand with this one.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9780

Example entry for configuration.yaml (if applicable):

lutron_caseta:
  host: 192.168.1.1
  keyfile: ./config/lutron/caseta.key
  certfile: ./config/lutron/caseta.crt
  ca_certs: ./config/lutron/caseta-bridge.crt

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [X ] There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
djj211 added 7 commits Nov 24, 2019
Copy link
Contributor

mdonoughe left a comment

@balloob requested a small refactor on #28886 which you'll need to account for here if that merges first.

homeassistant/components/lutron_caseta/fan.py Outdated Show resolved Hide resolved
homeassistant/components/lutron_caseta/fan.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 26, 2019
homeassistant/components/lutron_caseta/fan.py Outdated Show resolved Hide resolved
homeassistant/components/lutron_caseta/fan.py Outdated Show resolved Hide resolved
homeassistant/components/lutron_caseta/fan.py Outdated Show resolved Hide resolved
homeassistant/components/lutron_caseta/fan.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 26, 2019
@djj211

This comment has been minimized.

Copy link
Contributor Author

djj211 commented Nov 27, 2019

@MartinHjelmare Modifications completed. Note I added an additional mapping for FAN_MEDIUM_HIGH: SPEED_MEDIUM. Found a bug when testing out the changes in this PR. When setting the fan speed the mediumhigh directly on the switch, it would cause an error because I did not map the additional lutron speed.

It will seem that we need to revisit the concepts outlined in this architectural issue here as this seems to be a common occurrence for fan components: home-assistant/architecture#127

@djj211 djj211 requested a review from MartinHjelmare Nov 27, 2019
Copy link
Member

MartinHjelmare left a comment

Looks great!

Dev automation moved this from Review in progress to Reviewer approved Nov 28, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 28, 2019

@mdonoughe Ok to merge?

Copy link
Contributor

mdonoughe left a comment

lgtm

@MartinHjelmare MartinHjelmare merged commit 665613e into home-assistant:dev Nov 28, 2019
11 checks passed
11 checks passed
CI #20191127.116 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 06231e7...ebd8d55
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 28, 2019
@djj211 djj211 mentioned this pull request Nov 28, 2019
2 of 2 tasks complete
@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.