Add support for Somfy Camera Shutter #29057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinHjelmare
changed the title
balloob
reviewed
Nov 28, 2019
| return [ | ||
| SomfyCameraShutter(device, hass.data[DOMAIN][API]) | ||
| for device in devices | ||
| if categories & set(device.categories) |
There was a problem hiding this comment.
Suggested change
| if categories & set(device.categories) | |
| if Category.CAMERA.value in device.categories |
balloob
approved these changes
Nov 28, 2019
tetienne
force-pushed
the
somfy-camera
branch
from
6affc9c
to
739c928
Compare
|
@balloob Great! I've applied your modification. It should be OK now. |
frenck
approved these changes
Nov 28, 2019
| from pymfy.api.devices.camera_protect import CameraProtect | ||
| from pymfy.api.devices.category import Category | ||
|
|
||
| from homeassistant.components.somfy import DOMAIN, SomfyEntity, DEVICES, API |
There was a problem hiding this comment.
Intra package imports should be relative.
There was a problem hiding this comment.
I will.
from . import DOMAIN, SomfyEntity, DEVICES, API
7 tasks
|
@MartinHjelmare PR created: #29182 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change: N/A
Description: Add support for the Somfy Camera Shutter
See https://developer.somfy.com/products/cameras
Exemple of Somfy API answer with a camera: https://github.com/tetienne/somfy-open-api/blob/master/tests/camera.json
**Pull request with documentation for home-assistant.io (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed: N/A
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: N/A