Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Somfy Camera Shutter #29057

Merged
merged 1 commit into from Nov 28, 2019
Merged

Conversation

@tetienne
Copy link
Contributor

tetienne commented Nov 25, 2019

Breaking Change: N/A

Description: Add support for the Somfy Camera Shutter

See https://developer.somfy.com/products/cameras
Exemple of Somfy API answer with a camera: https://github.com/tetienne/somfy-open-api/blob/master/tests/camera.json

**Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed: N/A

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices: N/A

@MartinHjelmare MartinHjelmare changed the title ADD support for Somfy Camera Shutter Add support for Somfy Camera Shutter Nov 26, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 26, 2019
return [
SomfyCameraShutter(device, hass.data[DOMAIN][API])
for device in devices
if categories & set(device.categories)

This comment has been minimized.

Copy link
@balloob

balloob Nov 28, 2019

Member
Suggested change
if categories & set(device.categories)
if Category.CAMERA.value in device.categories
Copy link
Member

balloob left a comment

Looks good! One minor tweak and it's ok to merge 🎉 🐬

Dev automation moved this from Needs review to Reviewer approved Nov 28, 2019
@tetienne tetienne force-pushed the tetienne:somfy-camera branch from 6affc9c to 739c928 Nov 28, 2019
@tetienne

This comment has been minimized.

Copy link
Contributor Author

tetienne commented Nov 28, 2019

@balloob Great! I've applied your modification. It should be OK now.

@frenck
frenck approved these changes Nov 28, 2019
Copy link
Member

frenck left a comment

Thanks, @tetienne! 👍

@frenck frenck merged commit 4e107a2 into home-assistant:dev Nov 28, 2019
11 checks passed
11 checks passed
CI #20191128.17 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9c9e9bc...739c928
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 28, 2019
@tetienne tetienne deleted the tetienne:somfy-camera branch Nov 28, 2019
Copy link
Member

MartinHjelmare left a comment

Please address the comments in a new PR. Thanks!

from pymfy.api.devices.camera_protect import CameraProtect
from pymfy.api.devices.category import Category

from homeassistant.components.somfy import DOMAIN, SomfyEntity, DEVICES, API

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Nov 28, 2019

Member

Intra package imports should be relative.

This comment has been minimized.

Copy link
@tetienne

tetienne Nov 28, 2019

Author Contributor

I will.
from . import DOMAIN, SomfyEntity, DEVICES, API

homeassistant/components/somfy/switch.py Show resolved Hide resolved
@tetienne

This comment has been minimized.

Copy link
Contributor Author

tetienne commented Nov 28, 2019

@MartinHjelmare PR created: #29182

@lock lock bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.