Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intent integration to expose intent handle API #29124

Merged
merged 3 commits into from Nov 27, 2019
Merged

Add intent integration to expose intent handle API #29124

merged 3 commits into from Nov 27, 2019

Conversation

@balloob
Copy link
Member

balloob commented Nov 27, 2019

Description:

I realized that the Intent handle API endpoint shouldn't be in the conversation integration but instead be a new intent integration.

CC @synesthesiam

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob balloob requested a review from home-assistant/core as a code owner Nov 27, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 27, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (conversation) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Add intent integration to expose intent handle API. Add intent integration to expose intent handle API Nov 27, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@pvizeli pvizeli merged commit 004476a into dev Nov 27, 2019
11 checks passed
11 checks passed
CI #20191127.45 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch No report found to compare against
Details
codecov/project 94.5% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the intent-integration branch Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.