Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intent integration to expose intent handle API #29124

Merged
merged 3 commits into from Nov 27, 2019
Merged

Add intent integration to expose intent handle API #29124

merged 3 commits into from Nov 27, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 27, 2019

Description:

I realized that the Intent handle API endpoint shouldn't be in the conversation integration but instead be a new intent integration.

CC @synesthesiam

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner November 27, 2019 00:50
@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (conversation) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Add intent integration to expose intent handle API. Add intent integration to expose intent handle API Nov 27, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@pvizeli pvizeli merged commit 004476a into dev Nov 27, 2019
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the intent-integration branch November 27, 2019 10:25
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed core has-tests integration: conversation integration: intent new-integration
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balloob @MartinHjelmare @pvizeli @homeassistant