Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service domain for html5 from 'notify' to 'html5' #29145

Merged
merged 1 commit into from Nov 27, 2019
Merged

Update service domain for html5 from 'notify' to 'html5' #29145

merged 1 commit into from Nov 27, 2019

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Nov 27, 2019

Breaking Change:

This change breaks existing service call references to the notify.html5_* services by changing the service calls to be html5.*.

Description:

Update the domain and service name for html5.*. See this comment for context: #28890 (comment)

Related issue (if applicable): Related to #27289

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11320

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@raman325 raman325 requested review from robbiet480 and a team as code owners November 27, 2019 06:34
@probot-home-assistant probot-home-assistant bot added core integration: html5 small-pr PRs with less than 30 lines. labels Nov 27, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
@probot-home-assistant
Copy link

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (html5) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Nov 27, 2019
@pvizeli pvizeli merged commit fb9f561 into home-assistant:dev Nov 27, 2019
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@raman325 raman325 deleted the html5_service_update branch November 27, 2019 14:00
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants