Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Plex connection timeout to avoid config flow timeouts #29172

Merged
merged 1 commit into from Nov 27, 2019
Merged

Reduce Plex connection timeout to avoid config flow timeouts #29172

merged 1 commit into from Nov 27, 2019

Conversation

jjlawren
Copy link
Contributor

Description:

Config flows could time out if many connection options were available for a Plex server and the default timeout of 30s was used.

Related issue (if applicable): fixes #28564

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Nov 27, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 27, 2019
Dev automation moved this from By Code Owner to Reviewer approved Nov 27, 2019
@balloob balloob merged commit 88441d5 into home-assistant:dev Nov 27, 2019
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@jjlawren jjlawren deleted the plex_reduce_timeout branch November 27, 2019 22:17
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: plex small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown connection error in Plex integration setup
3 participants
@jjlawren @balloob @homeassistant