Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move intent registration to own integration #29280

Merged
merged 2 commits into from Dec 1, 2019
Merged

Move intent registration to own integration #29280

merged 2 commits into from Dec 1, 2019

Conversation

@balloob
Copy link
Member

balloob commented Dec 1, 2019

Breaking Change

If you use the built-in intents for shopping list, cover or light, you need to add intent: to your configuration.yaml.

Description:

This moves the integration intent registration that is currently done in async_setup by Shopping List, Cover and Light to be the responsibility of the Intent integration.

I am thinking that we should consider this pattern also for other things where integrations inter-relate. Like the frontend panels.

The idea is that it will open up the door to add more intents to all integrations without loading it when not needed.

CC @synesthesiam

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 1, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (cover) you are listed as a codeowner for? Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 1, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (intent) you are listed as a codeowner for? Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 1, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (conversation) you are listed as a codeowner for? Thanks!

@balloob balloob mentioned this pull request Dec 1, 2019
9 of 9 tasks complete
Dev automation moved this from Needs review to Reviewer approved Dec 1, 2019
@pvizeli
pvizeli approved these changes Dec 1, 2019
@MartinHjelmare MartinHjelmare changed the title Move intent registration to own integration. Move intent registration to own integration Dec 1, 2019
@balloob balloob merged commit d1aa0ce into dev Dec 1, 2019
12 checks passed
12 checks passed
CI #20191201.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 96.34% of diff hit (target 94.44%)
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the split-intent branch Dec 1, 2019
@lock lock bot locked and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.