Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to top for pencom #29348

Merged
merged 1 commit into from Dec 3, 2019

Conversation

springstan
Copy link
Member

Breaking Change:

Description:

Related issue (if applicable): fixes #27284

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Dec 3, 2019
@probot-home-assistant probot-home-assistant bot added integration: pencom small-pr PRs with less than 30 lines. labels Dec 3, 2019
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @springstan! 👍

Dev automation moved this from Needs review to Reviewer approved Dec 3, 2019
@frenck frenck merged commit 25b6740 into home-assistant:dev Dec 3, 2019
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
@springstan springstan deleted the move-imports-pencom branch December 16, 2019 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Migrate integrations to use top-level imports
3 participants