Add Elgato Key Light integration #29592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
balloob
reviewed
Dec 7, 2019
| # Cleanup | ||
| del hass.data[DOMAIN][entry.entry_id] | ||
| if not hass.data[DOMAIN]: | ||
| del hass.data[DOMAIN] |
There was a problem hiding this comment.
Don't clean this up, because it is not set by the config entry.
By deleting this, if we are to reload a single config entry, we would crash on line 36, because hass.data[DOMAIN] is no longer a dictionary.
There was a problem hiding this comment.
Addressed in 33023fe.
I moved it out of the setup, allowing both cleaning things up and prevent the described issue from occurring.
Is that an acceptable solution?
balloob
approved these changes
Dec 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for Elgato Key Lights to Home Assistant
https://www.elgato.com/en/gaming/key-light
Related issue (if applicable): n/a
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11391
Example entry for
configuration.yaml(if applicable): n/aChecklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: