Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort imports according to PEP8 for media_player #29665

Merged
merged 1 commit into from Dec 9, 2019

Conversation

basnijholt
Copy link
Contributor

Description:

I have sorted the imports for the media_player component according to PEP8 using isort.

This affects:

  • homeassistant/components/media_player/__init__.py
  • homeassistant/components/media_player/device_condition.py
  • homeassistant/components/media_player/reproduce_state.py
  • tests/components/media_player/common.py
  • tests/components/media_player/test_async_helpers.py
  • tests/components/media_player/test_device_condition.py
  • tests/components/media_player/test_init.py
  • tests/components/media_player/test_reproduce_state.py

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Dec 8, 2019
@basnijholt basnijholt mentioned this pull request Dec 9, 2019
9 tasks
Dev automation moved this from Needs review to Reviewer approved Dec 9, 2019
@frenck frenck changed the title sort imports according to PEP8 for media_player Sort imports according to PEP8 for media_player Dec 9, 2019
@frenck frenck merged commit eb47c2b into home-assistant:dev Dec 9, 2019
Dev automation moved this from Reviewer approved to Done Dec 9, 2019
@lock lock bot locked and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants