Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uvloop event policy #29835

Merged
merged 4 commits into from Dec 11, 2019
Merged

Remove uvloop event policy #29835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe94687
Remove uvloop event policy
pvizeli Dec 11, 2019
6bf49e9
Clean tests
pvizeli Dec 11, 2019
5b3789c
Fix lint
pvizeli Dec 11, 2019
0f3c097
Cleanup statment
pvizeli Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 1 addition & 11 deletions homeassistant/__main__.py
View file
Open in desktop
Expand Up @@ -15,12 +15,10 @@


def set_loop() -> None:
"""Attempt to use uvloop."""
"""Attempt to use different loop."""
import asyncio
from asyncio.events import BaseDefaultEventLoopPolicy

policy = None

if sys.platform == "win32":
if hasattr(asyncio, "WindowsProactorEventLoopPolicy"):
# pylint: disable=no-member
Expand All @@ -33,15 +31,7 @@ class ProactorPolicy(BaseDefaultEventLoopPolicy):
_loop_factory = asyncio.ProactorEventLoop

policy = ProactorPolicy()
else:
try:
import uvloop
except ImportError:
pass
else:
policy = uvloop.EventLoopPolicy()

if policy is not None:
asyncio.set_event_loop_policy(policy)


Expand Down
6 changes: 0 additions & 6 deletions tests/conftest.py
View file
Open in desktop
@@ -1,8 +1,6 @@
"""Set up some common test helper things."""
import asyncio
import functools
import logging
import os
from unittest.mock import patch

import pytest
Expand All @@ -25,10 +23,6 @@
)
from tests.test_util.aiohttp import mock_aiohttp_client # noqa: E402, isort:skip

if os.environ.get("UVLOOP") == "1":
import uvloop

asyncio.set_event_loop_policy(uvloop.EventLoopPolicy())

logging.basicConfig(level=logging.DEBUG)
logging.getLogger("sqlalchemy.engine").setLevel(logging.INFO)
Expand Down