Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tahoma component's tahoma-api requirement's version #29918

Merged
merged 1 commit into from Dec 14, 2019

Conversation

DjMoren
Copy link
Contributor

@DjMoren DjMoren commented Dec 13, 2019

Description:

After reverting the PR for removing Tahoma component, an update to the component's tahoma-api requirement must be done.

Related issue (if applicable): #29744 #29840

Example entry for configuration.yaml (if applicable):

tahoma:
  username: YOUR_USERNAME
  password: YOUR_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

@project-bot project-bot bot added this to Needs review in Dev Dec 13, 2019
@probot-home-assistant probot-home-assistant bot added integration: tahoma small-pr PRs with less than 30 lines. labels Dec 13, 2019
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete. The check list which you deleted contains all needed steps.

Dev automation moved this from Needs review to Review in progress Dec 13, 2019
@DjMoren
Copy link
Contributor Author

DjMoren commented Dec 13, 2019

@fabaff sorry for my error, it's been a newbie one trying to start collaborating here.

I've edited the PR comment and completed it except the one about tox, because I'm having problems with py36, py37, py38 and cov envs. They all have errors. I get this output:

ERROR:   py36: commands failed
ERROR:   py37: commands failed                                                                                                                                                                                                                                                                                                                                            
ERROR:   py38: commands failed                                                                                                                                                                                                                                                                                                                                            
  lint: commands succeeded
  pylint: commands succeeded                                                                                                                                                                                                                                                                                                                                              
  typing: commands succeeded                                                                                                                                                                                                                                                                                                                                              
ERROR:   cov: commands failed

The thing is that after every tox run, I get the errors in different parts, but it's supposed that I have to pass everything 🤔. Could you help me explaining why does this happen to me? Here are 2 different runs with pytest's -x option to stop in the first error: run1 and run2.

Thanks in advance for the help and for contributing into this great project.

@balloob balloob merged commit 3c86825 into home-assistant:dev Dec 14, 2019
Dev automation moved this from Review in progress to Done Dec 14, 2019
@balloob
Copy link
Member

balloob commented Dec 14, 2019

works now. Thanks!

Welcome to the Home Assistant community 🐬 🎉

@jensihnow
Copy link
Contributor

Thanks for picking this up. I really appreciate the tahoma integration being re-added as the open Somfy API is not at all feature complete. Support for most of the Somfy products is missing by Somfy. Having both allows to continue to use the not yet supported devices and functions in the meantime.

@DjMoren DjMoren deleted the fix/tahoma-api-version branch December 15, 2019 08:13
@lock lock bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants