New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tahoma component's tahoma-api requirement's version #29918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is incomplete. The check list which you deleted contains all needed steps.
3496655
to
6f8f9c5
Compare
@fabaff sorry for my error, it's been a newbie one trying to start collaborating here. I've edited the PR comment and completed it except the one about tox, because I'm having problems with py36, py37, py38 and cov envs. They all have errors. I get this output: ERROR: py36: commands failed
ERROR: py37: commands failed
ERROR: py38: commands failed
lint: commands succeeded
pylint: commands succeeded
typing: commands succeeded
ERROR: cov: commands failed The thing is that after every tox run, I get the errors in different parts, but it's supposed that I have to pass everything 🤔. Could you help me explaining why does this happen to me? Here are 2 different runs with pytest's -x option to stop in the first error: run1 and run2. Thanks in advance for the help and for contributing into this great project. |
works now. Thanks! Welcome to the Home Assistant community 🐬 🎉 |
Thanks for picking this up. I really appreciate the tahoma integration being re-added as the open Somfy API is not at all feature complete. Support for most of the Somfy products is missing by Somfy. Having both allows to continue to use the not yet supported devices and functions in the meantime. |
Description:
After reverting the PR for removing Tahoma component, an update to the component's tahoma-api requirement must be done.
Related issue (if applicable): #29744 #29840
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.