Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for legacy Z-Wave thermostats #29955

Merged
merged 1 commit into from Dec 16, 2019

Conversation

@oandrew
Copy link
Contributor

oandrew commented Dec 15, 2019

Description:

This brings back support for Z-Wave thermostats
of SETPOINT_THERMOSTAT specific device class.
Such devices don't have COMMAND_CLASS_THERMOSTAT_MODE
and are now handled separately.

fixes #29844

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
This brings back support for Z-Wave thermostats
of SETPOINT_THERMOSTAT specific device class.
Such devices don't have COMMAND_CLASS_THERMOSTAT_MODE
and are now handled separately.
@oandrew oandrew requested a review from home-assistant/z-wave as a code owner Dec 15, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 15, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 15, 2019

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with a integration (zwave) you are listed as a codeowner for? Thanks!

@tdobrovolny

This comment has been minimized.

Copy link

tdobrovolny commented Dec 15, 2019

I try oandrew:zwave-thermostat-bugfix with Danfoss Popp Radiator Thermostat (manf 2, type 115, id a010) and it works OK.

Version 0.102.3 - climate component of Danfoss Popp Radiator Thermostat - OK
Version 0.103.0 - climate component of Danfoss Popp Radiator Thermostat - disappeared
Version from oandrew:zwave-thermostat-bugfix - climate component of Danfoss Popp Radiator Thermostat - OK

@dshokouhi

This comment has been minimized.

Copy link
Contributor

dshokouhi commented Dec 15, 2019

We should make sure to tag this for 0.103.1

@cgarwood cgarwood added this to the 0.103.1 milestone Dec 16, 2019
@cgarwood cgarwood merged commit bfafa77 into home-assistant:dev Dec 16, 2019
12 checks passed
12 checks passed
CI #20191215.13 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.48%)
Details
codecov/project 94.53% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Dec 16, 2019
@lock lock bot locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.