New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rachio: Fix online sensor and standby switch #30031
Conversation
fixed self._handle_update on line 66 to produce args, kwargs. Updated the binary sensor to check the correct index in the tuple.
Set standby switch to poll in order to get status when homeassistant starts up. Updated the index for the switch to get the status from the tuple.
Tested with Hass.io, HA 0.103.0, iOS 13.3, iOS Companion 2.0, iPhone 8. Standby switch and binary sensor sync with Rachio mobile app correctly. Switch was toggled several times and monitored with the mobile app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
@springstan thank you! was worried since this is my first PR and didn't want to get yelled at :) |
@omriasta sure. Balmy 37 degrees here today. I tested my two zones. Both function as expected and indications from the Rachio mobile app, iOS Home, and HA are all accurate. I had no previous issues with the |
@garyak thanks for your help, I appreciate it! |
Thanks! Great first contribution. Welcome to the Home Assistant community 🐬 👋 |
Breaking Change:
Description:
Fix the Rachio Component so that the Online sensor and the standby switch both work properly
Related issue (if applicable):
Fixes #17667
Fixes #30012
Fixes #22256
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: