Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rachio: Fix online sensor and standby switch #30031

Merged
merged 2 commits into from Dec 18, 2019

Conversation

@omriasta
Copy link
Contributor

omriasta commented Dec 17, 2019

Breaking Change:

Description:

Fix the Rachio Component so that the Online sensor and the standby switch both work properly

Related issue (if applicable):
Fixes #17667
Fixes #30012
Fixes #22256

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
omriasta added 2 commits Dec 17, 2019
omriasta
fixed self._handle_update on line 66 to produce args, kwargs.
Updated the binary sensor to check the correct index in the tuple.
omriasta
Set standby switch to poll in order to get status when homeassistant starts up.
Updated the index for the switch to get the status from the tuple.
@garyak

This comment has been minimized.

Copy link

garyak commented Dec 18, 2019

Tested with Hass.io, HA 0.103.0, iOS 13.3, iOS Companion 2.0, iPhone 8. Standby switch and binary sensor sync with Rachio mobile app correctly. Switch was toggled several times and monitored with the mobile app.

Copy link
Member

springstan left a comment

Great work 👍

@omriasta

This comment has been minimized.

Copy link
Contributor Author

omriasta commented Dec 18, 2019

@springstan thank you! was worried since this is my first PR and didn't want to get yelled at :)
@garyak can you also make sure that the online sensor is working for you? Also not sure if you can test the zones? I hope I didn't mess anything up and I can't water here due to the weather....

@garyak

This comment has been minimized.

Copy link

garyak commented Dec 18, 2019

@omriasta sure. Balmy 37 degrees here today. I tested my two zones. Both function as expected and indications from the Rachio mobile app, iOS Home, and HA are all accurate. I had no previous issues with the binary_sensor.sprinklers_online function. So far, so good. Thanks again.

@omriasta

This comment has been minimized.

Copy link
Contributor Author

omriasta commented Dec 18, 2019

@garyak thanks for your help, I appreciate it!

@balloob balloob merged commit bdef54d into home-assistant:dev Dec 18, 2019
10 checks passed
10 checks passed
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 31cd0af...b89a684
Details
codecov/project 94.49% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Dec 18, 2019
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Dec 18, 2019

Thanks! Great first contribution. Welcome to the Home Assistant community 🐬 👋

@lock lock bot locked and limited conversation to collaborators Dec 19, 2019
@pvizeli pvizeli added this to the 0.103.3 milestone Dec 20, 2019
@balloob balloob changed the title Patch rachio Rachio: Fix online sensor and standby switch Dec 20, 2019
@omriasta omriasta deleted the omriasta:patch-rachio branch Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.