Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update port and api key on deconz discovery config entry update #30088

Merged
merged 2 commits into from Dec 20, 2019

Conversation

@frenck
Copy link
Member

frenck commented Dec 20, 2019

Description:

The deCONZ updates existing configuration entries in case new discovery information comes in, and the bridge ID is already a know/registered config entry.

However, it only updated the host parameter, not the port or API key.

This caused issues during the release of an updated version of the deCONZ Hass.io add-on. That release changed the port number, which didn't update.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Dec 20, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

@frenck frenck added this to the 0.103.3 milestone Dec 20, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 20, 2019
@MartinHjelmare MartinHjelmare changed the title Fix update port and api key on discovery config entry update Fix update port and api key on deconz discovery config entry update Dec 20, 2019
@frenck frenck merged commit eb0aed3 into dev Dec 20, 2019
10 checks passed
10 checks passed
CI Build #20191220.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.49%)
Details
codecov/project 94.49% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 20, 2019
@frenck frenck deleted the frenck-2019-0315 branch Dec 20, 2019
pvizeli added a commit that referenced this pull request Dec 20, 2019
* Fix update port and api key on discovery config entry update

* Remove coroutine from _update_entry
@pvizeli pvizeli mentioned this pull request Dec 20, 2019
@lock lock bot locked and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.