Fix update port and api key on deconz discovery config entry update #30088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: deconz
small-pr
pvizeli
approved these changes
Dec 20, 2019
MartinHjelmare
changed the title
pvizeli
pushed a commit
that referenced
this pull request
Dec 20, 2019
* Fix update port and api key on discovery config entry update * Remove coroutine from _update_entry
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The deCONZ updates existing configuration entries in case new discovery information comes in, and the bridge ID is already a know/registered config entry.
However, it only updated the host parameter, not the port or API key.
This caused issues during the release of an updated version of the deCONZ Hass.io add-on. That release changed the port number, which didn't update.
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: