Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - Handle wired bug on restart #30276

Merged

Conversation

@Kane610
Copy link
Member

Kane610 commented Dec 29, 2019

Description:

On restart wired bug timer will be set meaning something being affected by wired bug might erroneously get marked as home.

Related issue (if applicable): fixes #30162

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Kane610 Kane610 self-assigned this Dec 29, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 29, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 30, 2019
@andrewsayre

This comment has been minimized.

Copy link
Member

andrewsayre commented Dec 30, 2019

Test failure is a flakey test -- merging!

@andrewsayre andrewsayre added this to the 0.103.6 milestone Dec 30, 2019
@andrewsayre andrewsayre merged commit 41d2d1f into home-assistant:dev Dec 30, 2019
7 of 9 checks passed
7 of 9 checks passed
CI Build #20191229.25 had test failures
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Dec 30, 2019
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Dec 30, 2019

Thanks @andrewsayre

@Kane610 Kane610 deleted the Kane610:unifi-handle_wired_bug_on_restart branch Dec 31, 2019
@lock lock bot locked and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.