Add support for homekit air quality sensors #30510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MartinHjelmare
requested changes
Jan 5, 2020
|
Some integrations that handle data from other entities filter entities that report unknown state. This might become a problem in this case where this integration platform always reports unknown state for some users. |
|
I don't know if there actually are any HomeKit Air Quality sensors on the market that actually don't have the pm2.5 characteristic, so this might only be a theoretical problem. Can we wait and see if anyone has a problem? (I'm also hoping to make a few more requests in the arch repo after home-assistant/architecture#330 which might change the situation slightly). |
|
Sounds good! |
MartinHjelmare
approved these changes
Jan 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds support for the HomeKit
air-qualityservice type.Pull request with documentation for home-assistant.io (if applicable):
home-assistant/home-assistant.io#11641
Checklist:
tox. Your PR cannot be merged unless tests pass