New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate SimpliSafe property services #30567
Merged
bachya
merged 5 commits into
home-assistant:dev
from
bachya:simplisafe-property-services
Jan 13, 2020
Merged
Consolidate SimpliSafe property services #30567
bachya
merged 5 commits into
home-assistant:dev
from
bachya:simplisafe-property-services
Jan 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
MartinHjelmare
requested changes
Jan 9, 2020
@MartinHjelmare Anything else you'd like to see? |
MartinHjelmare
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
set_system_properties
service.set_pin
andremove_pin
services can now only be called by admin users.Description:
While experimenting with the various SimpliSafe property methods (set_chime_volume, etc.), I came to a realization: because SimpliSafe's cloud API anticipates receiving updated property values all at once, our method (sending properties one at a time) can result in failed updates if those calls happen too close together. This PR consolidates all of the relevant service calls into a single
set_system_properties
admin service (whose payload can include any/all system-related properties).Additionally, commentary by @MartinHjelmare made me realize that like this new service, the other services provided by the integration –
set_pin
andremove_pin
– are sensitive enough to require admin rights; this PR updates them to be admin services, as well.Related issue (if applicable): N/A
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11667
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
.