Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tahoma io:AwningValanceIOComponent #30944

Merged

Conversation

jensihnow
Copy link
Contributor

@jensihnow jensihnow commented Jan 18, 2020

Description:

Adds io:AwningValanceIOComponent (same like io:VerticalExteriorAwningIOComponent), sorts the devices and removes duplicate rts:BlindRTSComponent from cover.py. Following the issue #24673 the devices should be the same and behave like the same.

Related issue (if applicable): fixes #24673

Pull request with documentation for home-assistant.io (if applicable): -

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @philklei, mind taking a look at this pull request as its been labeled with a integration (tahoma) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Adds io:AwningValanceIOComponent (same like io:VerticalExteriorAwning… Add tahoma io:AwningValanceIOComponent Jan 22, 2020
@MartinHjelmare MartinHjelmare merged commit 15f6e28 into home-assistant:dev Jan 22, 2020
@jensihnow jensihnow deleted the AwningValanceIOComponent2 branch January 22, 2020 21:16
@lock lock bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tahoma component Unsupported type io:AwningValanceIOComponent
4 participants