Add zeroconf discovery support to Brother Printer integration #30959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jan 19, 2020
| return self.async_abort(reason="connection_error") | ||
|
|
||
| try: | ||
| if "Brother" not in user_input["name"]: |
There was a problem hiding this comment.
this is very weird code. Just do something like this pleaes:
if "Brother" not in user_input.get("name"):Also, do you want to check that it starts with, or is "Two Brothers on the fourth floor" ok too ?
balloob
reviewed
Jan 19, 2020
| # pylint: disable=no-member # https://github.com/PyCQA/pylint/issues/3167 | ||
| self.context.update( | ||
| { | ||
| CONF_HOST: host, |
There was a problem hiding this comment.
Please don't set the host in context. If it's for using the flow, just store it on self
balloob
reviewed
Jan 19, 2020
| """Handle a flow initiated by zeroconf.""" | ||
| try: | ||
| # pylint: disable=no-member # https://github.com/PyCQA/pylint/issues/3167 | ||
| brother = Brother(self.context.get(CONF_HOST)) |
There was a problem hiding this comment.
Why are we making this connection again? We should just keep this object around from async_step_zeroconf ?
balloob
reviewed
Jan 19, 2020
| if user_input is not None: | ||
|
|
||
| # Check if already configured | ||
| await self.async_set_unique_id(brother.serial.lower()) |
There was a problem hiding this comment.
You already did this in the previous step .
balloob
reviewed
Jan 19, 2020
| } | ||
| ) | ||
| return self.async_show_form( | ||
| step_id="zeroconf_confirm", |
There was a problem hiding this comment.
Don't render forms for other steps. Instead return await self.async_step_zeroconf_confirm()
MartinHjelmare
requested changes
Jan 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
This PR adds zeroconf discovery support to Brother Printer integration.
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: