Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OpenUV entities to be unavailable #31018

Merged
merged 2 commits into from Jan 20, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jan 20, 2020

Description:

This PR adds the available property to all OpenUV entities so that they properly render as unavailable in Lovelace.

Related issue (if applicable): fixes #30973

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

openuv:
  api_key: !secret openuv_api_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@bachya
Copy link
Contributor Author

bachya commented Jan 20, 2020

Not sure why CI is failing. 🤷‍♂

@frenck
Copy link
Member

frenck commented Jan 20, 2020

@bachya We've seen that a couple of time before today 😢

It is fixed by adding an empty commit.
git commit --allow-empty -m "Empty commit to re-trigger build"

@bachya bachya merged commit 662c127 into home-assistant:dev Jan 20, 2020
@bachya bachya deleted the openuv-availability branch January 20, 2020 20:34
@lock lock bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenUV: null instead of unknown
4 participants