Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled entities support to WLED #31040

Merged
merged 1 commit into from Jan 22, 2020
Merged

Add disabled entities support to WLED #31040

merged 1 commit into from Jan 22, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 21, 2020

Description:

Adds support for disabled entities to the WLED integration.
Also disables the free memory & uptime sensors by default on integration set up.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@MartinHjelmare MartinHjelmare added this to By Code Owner in Dev Jan 22, 2020
@MartinHjelmare
Copy link
Member

Is this a breaking change?

@MartinHjelmare
Copy link
Member

I think not, right? This option is only applied when the entity is first registered in the entity registry.

https://developers.home-assistant.io/docs/en/entity_registry_disabled_by.html#integrations-setting-default-value-of-disabled_by-for-new-entity-registry-entries

Dev automation moved this from By Code Owner to Reviewer approved Jan 22, 2020
MartinHjelmare
MartinHjelmare approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@frenck
Copy link
Member Author

frenck commented Jan 22, 2020

No this isn't a breaking change, this only applies to new instances of the integration.

@frenck frenck merged commit db76b91 into dev Jan 22, 2020
Dev automation moved this from Reviewer approved to Done Jan 22, 2020
@frenck frenck deleted the frenck-2020-0106 branch January 22, 2020 09:45
@lock lock bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: wled small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frenck @MartinHjelmare @homeassistant