Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard for callbacks in service helper #31339

Merged
merged 1 commit into from Jan 31, 2020
Merged

Guard for callbacks in service helper #31339

merged 1 commit into from Jan 31, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Jan 31, 2020 •
edited by MartinHjelmare

Breaking change

Proposed change

Fix two things:

  • Camera had an incorrectly callback function that was actually returning a coroutine
  • The service helper did not handle callbacks at all.

Fixes #31332

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

@balloob balloob added this to the 0.105.0 milestone Jan 31, 2020
@balloob balloob requested a review from a team as a code owner January 31, 2020 07:02
@project-bot project-bot bot added this to Needs review in Dev Jan 31, 2020
@Kane610
Copy link
Member

Kane610 commented Jan 31, 2020

I think you got the wrong issue mentioned :)

@MartinHjelmare MartinHjelmare changed the title Guard for callbacks Guard for callbacks in service helper Jan 31, 2020
Dev automation moved this from Needs review to Reviewer approved Jan 31, 2020
@MartinHjelmare
Copy link
Member

I've fixed the issue linking in the description.

@MartinHjelmare MartinHjelmare merged commit d405069 into dev Jan 31, 2020
Dev automation moved this from Reviewer approved to Done Jan 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the service-guard-callback branch January 31, 2020 08:32
pvizeli pushed a commit that referenced this pull request Jan 31, 2020
@balloob @pvizeli
Guard for callbacks in service helper (#31339)
c6baf02
@lock lock bot locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core integration: camera small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
0.105.0
Development

Successfully merging this pull request may close these issues.

Camera services cause exception after PR #31254
5 participants
@balloob @Kane610 @MartinHjelmare @pvizeli @homeassistant