Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing name to logging in DataUpdateCoordinator #32023

Merged
merged 1 commit into from Feb 20, 2020

Conversation

MatthewFlamm
Copy link
Contributor

Proposed change

Adds missing name to logging when reconnecting to data refresh.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@MatthewFlamm MatthewFlamm requested a review from a team as a code owner February 20, 2020 14:38
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Feb 20, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 20, 2020
Copy link
Member

@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 鉁岋笍

Dev automation moved this from Needs review to Reviewer approved Feb 20, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch indeed! Failing test is not related to this PR.

@frenck frenck added this to the 0.106.0 milestone Feb 20, 2020
@frenck frenck merged commit 6c9d4a6 into home-assistant:dev Feb 20, 2020
Dev automation moved this from Reviewer approved to Done Feb 20, 2020
@MatthewFlamm
Copy link
Contributor Author

Not sure why this test failed. hue seems to be the only user of this class so far, so it is possible it breaks the code somehow, but I'm not sure how that is possible.

@MatthewFlamm
Copy link
Contributor Author

馃 That this indeed is unrelated test failing.

@MatthewFlamm MatthewFlamm deleted the patch-1 branch February 20, 2020 16:09
@lock lock bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants