Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media_player: add Denon remote support #328

Merged
merged 3 commits into from Sep 10, 2015
Merged

media_player: add Denon remote support #328

merged 3 commits into from Sep 10, 2015

Conversation

ghost
Copy link

@ghost ghost commented Sep 6, 2015

Provides an interface to Denon Network Receivers.
Developed for a Denon DRA-N5, see http://www.denon.co.uk/chg/product/compactsystems/networkmusicsystems/ceolpiccolo

Is it possible to add two seperate play/pause buttons to the UI?

except (EOFError, BrokenPipeError, ConnectionResetError):
self._telnet.open(self._host)

_LOGGER.error(self._telnet.read_very_eager()) # skip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be here?

@rmkraus
Copy link
Contributor

rmkraus commented Sep 7, 2015

Looks good. There are, what looks like, a few debug lines floating around in there. Creating separate play and pause buttons is possible, but would require an update to the Frontend.

@fabaff
Copy link
Member

fabaff commented Sep 8, 2015

This is a stub for the documentation. Please feel free to make suggestions to improve the page. Thanks.

@balloob
Copy link
Member

balloob commented Sep 9, 2015

Two play/pause buttons is currently not supported. It is supported to create two media player devices for each media player.

@ghost
Copy link
Author

ghost commented Sep 9, 2015

It looks like their API doesn't allow you to determine if the receiver is playing or not.

That's true, I tried some hacks but dropped the idea of parsing display information as it is too complicated and unreliable.

Creating separate play and pause buttons is possible, but would require an update to the Frontend.

Then I'll just leave it as it is.

It is supported to create two media player devices for each media player.

No, I'd need a pause button and a play button because I cannot be sure whether the player is currently playing or not.


There are, what looks like, a few debug lines floating around in there.

Fixed, thank you for pointing out :-)
I did not test the new code yet, but as it did not change much, I believe it should work fine.


This is a stub for the documentation.

You are awesome. I love this project, not because of the device support but because it is so easy to create new modules and contribute them 👍
Thank you for writing the documentation for me. At the moment, I have nearly no time for anything.
Both of you are really encouraging ❤️

balloob added a commit that referenced this pull request Sep 10, 2015
media_player: add Denon remote support
@balloob balloob merged commit 3a8119a into home-assistant:dev Sep 10, 2015
@ghost ghost mentioned this pull request Oct 23, 2015
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants