Adding timer setting functionality to sonos component #3941
Conversation
|
@americanwookie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SEJeff, @balloob and @robbiet480 to be potential reviewers. |
| @@ -157,6 +172,11 @@ def _restore_service(service): | |||
| _apply_service(service, SonosDevice.restore) | |||
|
|
|||
|
|
|||
| def _set_sleep_timer_service(service): | |||
| """Set a timer.""" | |||
| _apply_service(service, SonosDevice.set_sleep_timer, service.data[ATTR_SLEEP_TIME]) | |||
There was a problem hiding this comment.
- 80: E501 line too long (87 > 79 characters)
americanwookie
force-pushed
the
sonos_add_timers
branch
3 times, most recently
from
9c7cb57
to
83ade1b
Compare
| @only_if_coordinator | ||
| def set_sleep_timer(self, sleep_time): | ||
| """Set the timer on the player.""" | ||
| if sleep_time != '': |
There was a problem hiding this comment.
You're having a service schema validation that ensures it's always an int > 0
| def set_sleep_timer(self, sleep_time): | ||
| """Set the timer on the player.""" | ||
| if sleep_time != '': | ||
| if int(sleep_time) > 86399: |
There was a problem hiding this comment.
Sleep time will always be an int. However, if you also want to have this validation you need to use the following:
vol.Required(ATTR_SLEEP_TIME): vol.All(vol.Coerce(int), vol.Range(min=0, max=86399))There was a problem hiding this comment.
Good point. I'm going to fix this. Additionally, I think we need one more method for "Cancel the sleep timer, if one exists". I'll get this in by the weekend.
|
I'm on vacation until Saturday and won't have access to Sonos kit to test until I get home. |
americanwookie
force-pushed
the
sonos_add_timers
branch
from
a205a4f
to
b38e359
Compare
| @@ -0,0 +1,115 @@ | |||
| diff --git a/homeassistant/components/media_player/services.yaml b/homeassistant/components/media_player/services.yaml | |||
There was a problem hiding this comment.
foo right? Oops. Should be fixed.
americanwookie
force-pushed
the
sonos_add_timers
branch
from
b38e359
to
dc10801
Compare
Sleep timers can be used with Sonos to configure a speaker (or set of speakers) to taper down the volume to 0 and stop music after a specific number of seconds. Also, if you want your speakers to gracefully taper down immediately, you can pass it 0 seconds.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#1273
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py. (Truth be told: I edited the single relevant line).coveragerc. (I think we're not doing coveragerc for sonos)