Added some extra options to Weather Underground component #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @arsaboo, @Teagan42 and @fabaff to be potential reviewers. |
|
@rpitera could you please the options added and reports the results? Thanks! |
|
Everything is showing up correctly in my tests here. All new options are now displaying correctly as well! Nice work. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added some extra options to Weather Underground component.
NOTE: The options added will not add any payload or extra call to the WU API
Feature Request: https://community.home-assistant.io/t/weather-underground-wunderground-weather-sensor/1849/29
Pull request in [home-assistant.github.io]: home-assistant/home-assistant.io#1418
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass