Pin versions on linters for tests #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sdague, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob and @fabianhjr to be potential reviewers. |
The linters really need to specify an exact version, because when either flake8 or pylint release a new version, a whole lot of new issues are caught, causing failures on the code unrelated to the patches being pushed. Pinning is a best practice for linters. This allows patches which move forward the linter version to happen with any code fixes required for it to pass.
|
Merging this to get tests running again for new contributors. Please feel free to modify later if we want something less strict than this. |
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linters really need to specify an exact version, because when
either flake8 or pylint release a new version, a whole lot of new
issues are caught, causing failures on the code unrelated to the
patches being pushed.
Pinning is a best practice for linters. This allows patches which move
forward the linter version to happen with any code fixes required for
it to pass.