Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve some bugs in the broadlink switch #5022

Merged
merged 2 commits into from Dec 21, 2016
Merged

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Dec 20, 2016

Description:
If several broadlink devices are used, the learn service should be given separate names.
The learn service is also only needed for rm devices.

The other bugs I have seen have to wait until @mjg59 has merged these prs: https://github.com/mjg59/python-broadlink/pulls/Danielhiversen

Related issue (if applicable): fixes parts of #4997

Checklist:

If the code communicates with devices, web services, or third-party tools:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@Danielhiversen Danielhiversen merged commit 39bdd53 into dev Dec 21, 2016
@Danielhiversen Danielhiversen deleted the broadlink_bug_fix branch December 21, 2016 04:24
@home-assistant home-assistant locked and limited conversation to collaborators Mar 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant