Add EBox sensor component #5135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@titilambert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @rmkraus to be potential reviewers. |
houndci-bot
reviewed
Jan 1, 2017
| usage_data = {} | ||
| # Get data | ||
| for key, index in USAGE_MAP.items(): | ||
| usage_data[key] = abs(float(span_list[index].text.strip().split()[0])) |
houndci-bot
reviewed
Jan 1, 2017
| return False | ||
| # Get percent | ||
| try: | ||
| home_data["usage"] = float(soup.find("div", {"id": "circleprogress_0"}).\ |
There was a problem hiding this comment.
line too long (85 > 79 characters)
the backslash is redundant between brackets
houndci-bot
reviewed
Jan 1, 2017
| return False | ||
| # Get balance | ||
| try: | ||
| home_data["balance"] = float(soup.find("div", {"class": "text_amount"}).text.split()[0]) |
There was a problem hiding this comment.
line too long (100 > 79 characters)
houndci-bot
reviewed
Jan 1, 2017
| "upload": 7, | ||
| "total": 8} | ||
|
|
||
| def setup_platform(hass, config, add_devices, discovery_info=None): |
houndci-bot
reviewed
Jan 1, 2017
|
|
||
| _LOGGER = logging.getLogger(__name__) | ||
|
|
||
| GIGABITS = "Gb" # type: str |
There was a problem hiding this comment.
at least two spaces before inline comment
titilambert
force-pushed
the
ebox
branch
5 times, most recently
from
b9bf85f
to
025c01c
Compare
titilambert
force-pushed
the
ebox
branch
2 times, most recently
from
51b57c6
to
3b175c9
Compare
balloob
reviewed
Jan 17, 2017
| self._state = round(self.ebox_data.data[self.type], 2) | ||
|
|
||
|
|
||
| class EBoxData(object): |
There was a problem hiding this comment.
This platform contains too much protocol specific details. Please extract into a 3rd party lib and base it upon that.
|
I'll close this for now. Please reopen when extracted as third party lib and updated the code. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add EBox sensor component.
EBox is an Internet provider in Canada.
This component uses https://client.ebox.ca
Note: This component will be updated once EBox releases their rest API
Pull request in home-assistant.github.io with documentation : home-assistant/home-assistant.io#1694
Example entry for
configuration.yaml(if applicable):Checklist:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.