Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fluxled discovery. #5784

Merged
merged 2 commits into from Feb 8, 2017

Conversation

aequitas
Copy link
Contributor

@aequitas aequitas commented Feb 6, 2017

Description: see title.

Related issue (if applicable): home-assistant-libs/netdisco#91

@mention-bot
Copy link

@aequitas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Danielhiversen, @balloob and @fabaff to be potential reviewers.

@aequitas
Copy link
Contributor Author

aequitas commented Feb 6, 2017

I think I found a source to obtain more device type -> mode mappings. Have to investigate if it is usable though.

@Danielhiversen
Copy link
Member

Danielhiversen commented Feb 6, 2017

It is just added some automatic device protocol detection:
Danielhiversen/flux_led#23
Maybe you can use that?

@aequitas
Copy link
Contributor Author

aequitas commented Feb 6, 2017

That could be useful indeed, it looks like it probes the device capabilities after it has been added based on the returned status, am I right?

What I have been looking into is decompiling the MagicHome app and inspecting how they to the type recognition based on the device ID. They basically match device type (sub)strings to features. It should be doable to port it to Python but I don't know if it is legal.

@aequitas
Copy link
Contributor Author

aequitas commented Feb 6, 2017

@Danielhiversen added you suggested solution. Works for me. But I don't have many devices to test.

@Danielhiversen
Copy link
Member

I can test it tomorrow.

Copy link
Member

@Danielhiversen Danielhiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great.
The code looks fine.
I will not be able to test it the next 10 days.
But I think it is good to merge.
Remember to upgrade the netdisco library before merging this.

@balloob
Copy link
Member

balloob commented Feb 8, 2017

Robbie already upgraded the netdisco lib so good to go 🐬

@balloob balloob merged commit 0e6dd39 into home-assistant:dev Feb 8, 2017
@aequitas aequitas deleted the fluxled_discovery branch February 8, 2017 11:41
@home-assistant home-assistant locked and limited conversation to collaborators May 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants