New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for fluxled discovery. #5784
Conversation
@aequitas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Danielhiversen, @balloob and @fabaff to be potential reviewers. |
I think I found a source to obtain more device type -> mode mappings. Have to investigate if it is usable though. |
It is just added some automatic device protocol detection: |
That could be useful indeed, it looks like it probes the device capabilities after it has been added based on the returned status, am I right? What I have been looking into is decompiling the MagicHome app and inspecting how they to the type recognition based on the device ID. They basically match device type (sub)strings to features. It should be doable to port it to Python but I don't know if it is legal. |
@Danielhiversen added you suggested solution. Works for me. But I don't have many devices to test. |
I can test it tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
The code looks fine.
I will not be able to test it the next 10 days.
But I think it is good to merge.
Remember to upgrade the netdisco library before merging this.
Robbie already upgraded the netdisco lib so good to go 🐬 |
Description: see title.
Related issue (if applicable): home-assistant-libs/netdisco#91