Fix attribute error for media_player/roku if roku device is unreachable and shows a persistent notification #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and shows a persistent notification (home-assistant#5785)
|
@tchellomello, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bah2830, @robbiet480 and @fabaff to be potential reviewers. |
Ordep
pushed a commit
to Ordep/home-assistant
that referenced
this pull request
Feb 9, 2017
…le and shows a persistent notification (home-assistant#5785) (home-assistant#5786)
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This patch fixes the attribute error for media_player/roku if roku device is unreachable and shows a persistent notification.
Related issue (if applicable): fixes #5785
Example entry for
configuration.yaml(if applicable):Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.