New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sqlite's WAL mode to avoid database is locked
errors
#6519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what the impact of this setting is, but we should only set it when we're using SQLite as the engine |
Seems to work okay with postgres (at least with the latest commit that checks for |
balloob
approved these changes
Mar 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok to merge when conflicts resolved.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending PR to help prompt discussion hopefully, likely still a WIP (due to my lack of in-depth knowledge in the area).
Code:
Description:
Try using sqlite
WAL
mode to fix "database is locked" errors. Please see: #4780 (comment)(sqlite3.OperationalError) database is locked
is [a common error](https://github.com/home-assistant/home-assistant/issues?utf8=✓&q=is%3Aissue%20database%20is%20locked encountered by HomeAssistant newbies using devices like Raspberry Pi.WAL
mode helps facilitate simultaneous read and write for simple sqlite databases which seems to help alleviate this error. The major drawback to this mode seems to be its requirement for a relatively recent version of sqlite, which seems to be satisfied on a standard Raspbian Jessie / Python 3.4 setup:Related issue (if applicable): fixes #4780
If the code does not interact with devices:
tox
run successfully. Your PR cannot be merged unless tests pass