Integration with lockitron #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aarya123, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @robbiet480 to be potential reviewers. |
pvizeli
requested changes
Mar 27, 2017
| self.device_id = device_id | ||
|
|
||
| @property | ||
| def should_poll(self): |
| def lock(self, **kwargs): | ||
| """Lock the device.""" | ||
| self._state = self.do_change_request(Lockitron.LOCK_STATE) | ||
| self.update_ha_state() |
There was a problem hiding this comment.
Not needed while it is a polling device
| def unlock(self, **kwargs): | ||
| """Unlock the device.""" | ||
| self._state = self.do_change_request(Lockitron.UNLOCK_STATE) | ||
| self.update_ha_state() |
There was a problem hiding this comment.
Not needed while it is a polling device
|
Updated! |
pvizeli
approved these changes
Mar 29, 2017
|
Good work 👍 |
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support to lockitrons that have the bridge extension that enables wi-fi support. Currently only supports one lock at a time.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.io#2339
Example entry for
configuration.yaml(if applicable):Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass