Add voluptuous config validation to scenes #6830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add platform schema to scene component and homeassistant platform. * Clean up code and add constants. * Add unit test and clean up tests.
|
@MartinHjelmare, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @pvizeli and @sander76 to be potential reviewers. |
balloobbot
added
core
platform
and removed
cla-signed
integration: scene
platform: scene.homeassistant
labels
balloob
reviewed
Mar 29, 2017
| vol.Schema({ | ||
| vol.Required(CONF_PLATFORM): cv.platform_validator(DOMAIN) | ||
| }, extra=vol.ALLOW_EXTRA), | ||
| _platform_validator |
There was a problem hiding this comment.
Isn't this automatically done by async_setup_component when it detects a PLATFORM_SCHEMA ?
https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/config.py#L540-L572
Edit: oh realized now that it is not happening for hass platforms because we support the old config too.
|
Nice! 🐬 |
|
I had some time to try this out and so far it works perfectly. Scenes within packages get merged! Thanks a lot :) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable):
fixes #6641, closes #6815
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass