Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zwave cover invert workaround. Use config instead. #6832

Merged
merged 1 commit into from Mar 28, 2017
Merged

Remove zwave cover invert workaround. Use config instead. #6832

merged 1 commit into from Mar 28, 2017

Conversation

andrey-git
Copy link
Contributor

Description:

Remove zwave cover invert workaround. Use config instead.

Following #6762
Fixes: #6421

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

zwave:
  device_config:
    cover.my_cover:
      invert_openclose_buttons: true

Checklist:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@andrey-git andrey-git mentioned this pull request Mar 28, 2017
Closed
turbokongen
turbokongen approved these changes Mar 28, 2017
View reviewed changes
Copy link
Contributor

@turbokongen turbokongen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :+1

@andrey-git andrey-git merged commit fb8323f into home-assistant:dev Mar 28, 2017
@andrey-git andrey-git deleted the zwave_invert branch March 28, 2017 20:01
@fabaff fabaff mentioned this pull request Apr 6, 2017
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 17, 2017
@ghost ghost removed the platform: cover.zwave label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emlove emlove emlove approved these changes

@turbokongen turbokongen turbokongen approved these changes

Assignees
No one assigned
Labels
breaking-change cla-signed integration: zwave Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zwave Fibaro FGRM222 Roller Shutter Controller has more than one type/id
4 participants
@andrey-git @emlove @turbokongen @homeassistant