New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix wait on start event #7013

Merged

balloob merged 5 commits into home-assistant:dev from pvizeli:fix_wait_on_start

Apr 11, 2017

Member

pvizeli commented Apr 10, 2017 •

edited

Description:

This protect to track new task after we schedule all EVENT_HOMEASSISTANT_START listener task. Otherwise we can block forever there.

I remove also the assert on block_till_done while that is not needed. We support no task track in this function.

mention-bot commented Apr 10, 2017

@pvizeli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @balloob, @fabaff and @jaharkes to be potential reviewers.

homeassistant added the cla-signed label

balloobbot added core and removed cla-signed labels

pvizeli requested a review from balloob

April 10, 2017 06:40

pvizeli added this to the 0.42.3 milestone

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 500de36 to d95b683 Compare

April 10, 2017 08:36

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 10cdfa2 to 0457237 Compare

April 10, 2017 15:03

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 3452b25 to 8fe968c Compare

April 10, 2017 16:20

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 708b70e to 8fe968c Compare

April 10, 2017 16:57

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 2481c03 to 6e30be1 Compare

April 10, 2017 17:11

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 9eedcc6 to c945ef0 Compare

April 10, 2017 18:05

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from c945ef0 to 8fe968c Compare

April 10, 2017 20:43

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 7a2d8f6 to 981dfd5 Compare

April 10, 2017 21:24

homeassistant added the cla-signed label

pvizeli force-pushed the fix_wait_on_start branch from 981dfd5 to 8fe968c Compare

April 10, 2017 21:57

homeassistant added the cla-signed label

Member Author

pvizeli commented Apr 11, 2017 •

edited

@balloob for me is now okay. It is clean and nice solution. It is also a small cleanup

homeassistant added the cla-signed label

pvizeli and others added 3 commits

April 11, 2017 14:40


          Bugfix wait on start event

ae0e16e


          Paulus sugestion

489bf6a


          Change handling with stop_track_task

70ef899


          Add new unittests

138ad41

pvizeli force-pushed the fix_wait_on_start branch from 8124028 to 138ad41 Compare

April 11, 2017 12:41

homeassistant added the cla-signed label


          Update test_core.py

28a50fa

balloob merged commit b52cabf into home-assistant:dev

balloob pushed a commit that referenced this pull request


          Bugfix wait on start event (#7013)

7377ce2

* Bugfix wait on start event

* Paulus sugestion

* Change handling with stop_track_task

* Add new unittests

* Update test_core.py

balloob mentioned this pull request

Merged

Member

balloob commented Apr 11, 2017

Cherry picked for 0.42.3

jimbob1001 mentioned this pull request

0.42.3 homeassistant platform not triggering automation on restart #7058

Closed

balloob mentioned this pull request

Merged

home-assistant locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.